-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EcdsaKeypair::try_sign
sometimes fail with Error::FormatEncoding
#170
Comments
Aah indeed. This seems like a bug in |
tarcieri
added a commit
that referenced
this issue
Oct 20, 2023
Changes the method to allow leading zeroes, stripping them and readding a leading one if need be. Closes #170
#171 should provide a fix |
tarcieri
added a commit
that referenced
this issue
Oct 20, 2023
Changes the method to allow leading zeroes, stripping them and readding a leading one if need be. Closes #170
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
p256::ecdsa::Signature::split_bytes
may return byte slices that start with0
, i.e. a negative SSHmpint
, causingError::FormatEncoding
to be returned when being encoded as positive SSHmpint
in the following code fromsignature.rs
.The tests below demonstrate this error.
The text was updated successfully, but these errors were encountered: