ssh-key: Implement SkEcdsaSha2NistP256 signature validation #169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change implements validation of of sk-ecdsa signatures as emitted by the openssh ssh-agent. The signature format is analogous to the sk-ed25519 sinature format already supported by ssh-key
|
I can confirm that building the pam-ssh-agent against this commit will result in a pam module that can authenticate users using a |
|
Awesome work, thanks! I can hopefully review this weekend. |
|
Just a friendly remind of this :) |
|
Sorry, this has been sitting in my inbox and I meant to get to it |
tarcieri
reviewed
Nov 18, 2023
tarcieri
approved these changes
Nov 18, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently obtained a Yubikey Series 5 hardware token with the ability to generate and use sk-ecdsa type keys with openssh. It seemed like a good addition to the ssh-key crate to implement validation of signatures generated using such keys, as this is not yet supported and depending on firmware version of the hardware token, this is sometimes the only key type it can handle.
The signature is generated with OpenSSH_9.5p1 tools and the resulting signature is captured using my https://github.com/nresare/ssh-agent-client-rs library
I have made some slightly more opinionated changes compared to last time around, breaking out shared functionality into private helper functions in signature.rs. Just let me know what you think, and I'm happy to restructure to match your preferences.