Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Problem with mont form inversion #606

Closed
wants to merge 8 commits into from
Closed

Problem with mont form inversion #606

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
cce105a
Test to illustrate a mont form inversion problem
dvdplm Jun 11, 2024
723aa4c
Update descr
dvdplm Jun 11, 2024
2f050b7
Rewrite tests using public API
dvdplm Jun 13, 2024
5063f50
Add a test using `num-modular`
dvdplm Jun 14, 2024
6c803e6
Add v0.5.5 as dev-dep
dvdplm Jun 18, 2024
3f84e2d
Lockfile
dvdplm Jun 18, 2024
e0da58b
More tests, better description, cleanup
dvdplm Jun 20, 2024
d3b2d7c
Merge branch 'master' into dp-BY-inversion
dvdplm Jun 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ num-modular = { version = "0.6", features = ["num-bigint", "num-integer", "num-t
proptest = "1"
rand_core = { version = "0.6", features = ["std"] }
rand_chacha = "0.3"
crypto_bigint_05 = {package = "crypto-bigint", version = "0.5.5"}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind removing this dependency and the tests that depend on it, leaving only tests against the current codebase with fixed vectors?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I mean, this PR is just a throw-away thing to tinker with a tricky bug and this was convenient for that purpose. If there's anything we salvage here long term it's perhaps the test vectors, but perhaps we can put those in your other PR?


[features]
default = ["rand"]
Expand Down
Loading
Loading