polyval: pin nightly version used for ARMv8 testing
#151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The build is currently failing: https://github.com/RustCrypto/universal-hashes/runs/5629586918?check_suite_focus=true It's for two reasons: 1. `aarch64_target_feature` was recently stabilized in rust-lang/rust#90621 but we still include it 2. There's a bug releating to `neon`/`fp` activation. See rust-lang/rust#91608 and rust-lang/rust#95044 Until one of the fixes in the second issue is merged, we can't really make progress. So this commit pins to `nightly-2022-03-01` so we can continue to have a clean build. Once either of the above solutions lands we can remove `aarch64_target_feature` and unpin nightly again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build is currently failing:
https://github.com/RustCrypto/universal-hashes/runs/5629586918?check_suite_focus=true
It's for two reasons:
aarch64_target_featurewas recently stabilized in Stabiliseaarch64_target_featurerust-lang/rust#90621 but we still include itneon/fpactivation. See Fold aarch64 feature +fp into +neon rust-lang/rust#91608 and Fix unnecessary error when usingneontarget feature rust-lang/rust#95044Until one of the fixes in the second issue is merged, we can't really make progress. So this commit pins to
nightly-2022-03-01so we can continue to have a clean build.Once either of the above solutions lands we can remove
aarch64_target_featureand unpin nightly again.