hybrid-array: add slice_as_chunks(_mut) methods, minor refactoring #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
reviewed
Oct 27, 2023
|
#951 seems somewhat related, though not something I'm suggesting we necessarily tackle in this PR |
tarcieri
approved these changes
Oct 27, 2023
Yeah, we can do it in a separate PR. I wonder if it can be handled by |
|
@newpavlov that's the sort of line of thinking I was curious about, i.e. how to compose various types of (reference) conversions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed here these functions will allow us to remove a bit of
unsafefrom downstream crates and it will be useful for users who would like to work with blocks of data.