-
-
Notifications
You must be signed in to change notification settings - Fork 29
fix: fix undefined "generator.filename" option #101
Conversation
This PR has been automatically marked stale because it it received no activity for 60 days. If you wish to keep this open, please leave a comment. Thanks. |
This PR has been automatically closed because it received no activity for 60 days. If you think this was closed by accident, please leave a comment. Thanks. |
@RyanClementsHax Could you reopen and review this PR, please? With nrwl/nx#12276 and the fallbacks in this PR, the issue #100 should be solved👍 |
Hi there @RyanClementsHax ! Can you please take a look at this, and please reopen? Let me know if you need any help reviewing! It would really help with the Nx integration! |
🎉 This PR is included in version 1.6.10 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Thank you SO much @RyanClementsHax !!!! :D |
No prob thanks for helping to test :) |
The issue that this fixed is currently present in the @storybook/nextjs framework. I can make a PR to copy this change over to that as well. |
This issue RyanClementsHax/storybook-addon-next#100 involving storybook-addon-next and the nx plugin @nx/react/plugin/storybook was resolved RyanClementsHax/storybook-addon-next#101, but that fix didn't make it to this equivalent file here in @storybook/nextjs, making that issue still present when using Storybook 7 and @storybook/nextjs as the framework.
I'd be happy to review any PRs :) |
fixes #100