fix for fluid/gas icons from mods & mipmapping from base #42
Conversation
Foreman/DataCache.cs
Outdated
| { | ||
| if (iconImage.GetPixel(i, j).A != 0) | ||
| { | ||
| iconImage.SetPixel(i, j, tintColor); |
There was a problem hiding this comment.
I'm not familiar with this API but is there not a "blend" function or something?
There was a problem hiding this comment.
not for System.Drawing.Color :(
but i'm not blending anyway, i just override the pixel if alpha is > 0, which shouldnt be to bad anyway
other option would be to convert the image to a byteArray[][] and do the operation there, but i just wanted to get it working first^^
Foreman/DataCache.cs
Outdated
| } | ||
| catch (Exception e) | ||
| { | ||
| // whatever |
There was a problem hiding this comment.
Please include error logging here.
There was a problem hiding this comment.
sometimes there are no tables for "shift" or "tint" or whatever and since NLua kinda sucks, i can only check for it with try/catch and then check if it's == null
so i really wouldn't go and catch those errors, bloats my errorlog to ~200KB
Foreman/DataCache.cs
Outdated
| } | ||
| catch (Exception e) | ||
| { | ||
| // whatever |
There was a problem hiding this comment.
Please include error logging here
No description provided.