Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a small but important change to the
RemoteData<'T>
type:| Loading
becomes
| Loading of 'T option
this is very useful for refresh scenarios, whereby you load data and then need to load it again later. Without this, you "lose" the existing data whilst refreshing, which can cause e.g. flickering on screen. There is the
RefreshableRemoteData
type but it is somewhat limited - it has no built-in functionality such asmap
etc. and is somehow awkward to use. Now, if you just want to load data up-front once, you would haveLoading None
during the load. If you're refreshing and want to keep the current data, then you would put it intoLoading (Some xxx)
.I've added extra
///
comments to aid this change, and adding some an extra memberIsRefreshing
, and updated the existing members to act appropriately on Loading data e.g.map
,defaultValue
,hasData
etc.Thoughts?