quick readme update for file exclusion #22
Conversation
|
|
| @@ -221,6 +222,8 @@ Default: component namespace path + `/**` (e.g. `my/app/**`) | |||
| Glob pattern(s) for files that should be included into the preload. | |||
| Patterns are based on all available resources (see [resources](#resources)). | |||
|
|
|||
| **Note:** You can exclude files by prepending the exclamation mark, like so: ```!my/app/ignore.js```. | |||
|
|
|||
| ### libraries | |||
|
|
|||
| See [components](#components). Auto mode is looking for `library.js` files. | |||
There was a problem hiding this comment.
I think we should also add a note here. As the current default pattern does only include **/*.fragment.json files but not library-preload.json we don't really need a equivalent exclude for libraries.
|
When doing the review I again thought about this change and there might be a use case to include
I would rather do a check independent of the include/exclude patterns to prevent including an output file ( |
|
@agraebe do you want to follow up on this? |
|
I think we should approach with your suggestions, sorry for the late response! |
|
See #25 (documentation update is missing there. I'll add that later). Let me know if this suits your needs. |
|
As there was no further feedback I merged #25 which will be included in the next release. I did not adopt the README.md as the behavior should be quite obvious. |
No description provided.