Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CSNM] Add new object type CSNM #557

Merged
merged 22 commits into from
Oct 4, 2023
Merged

[CSNM] Add new object type CSNM #557

merged 22 commits into from
Oct 4, 2023

Conversation

michaelbelenki
Copy link
Contributor

No description provided.

@cla-assistant
Copy link

cla-assistant bot commented Sep 22, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@cla-assistant
Copy link

cla-assistant bot commented Sep 22, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@albertmink

This comment was marked as resolved.

Sign in to view
schneidermic0
schneidermic0 requested changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@schneidermic0 schneidermic0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments/questions below

file-formats/csnm/type/zif_aff_csnm_v1.intf.abap Outdated Show resolved Hide resolved
file-formats/csnm/examples/z_aff_example_csnm.csnm.json Outdated Show resolved Hide resolved
file-formats/csnm/examples/z_aff_example_csnm.csnm.json Outdated Show resolved Hide resolved
schneidermic0
schneidermic0 approved these changes Sep 26, 2023
View reviewed changes
Copy link
Contributor

@schneidermic0 schneidermic0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Let's review it by @SAP/abap-file-formats-ux

@wurzka wurzka requested a review from a team September 29, 2023 14:03
wurzka
wurzka requested changes Sep 29, 2023
View reviewed changes
Copy link
Contributor

@wurzka wurzka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We were able to perform the UX review for CSNM. See my comments below.

file-formats/csnm/type/zif_aff_csnm_v1.intf.abap Outdated Show resolved Hide resolved
file-formats/csnm/type/zif_aff_csnm_v1.intf.abap Outdated Show resolved Hide resolved
file-formats/csnm/type/zif_aff_csnm_v1.intf.abap Outdated Show resolved Hide resolved
wurzka
wurzka approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@wurzka wurzka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes. Looks good to me 👍

schneidermic0
schneidermic0 approved these changes Oct 4, 2023
View reviewed changes
Copy link
Contributor

@schneidermic0 schneidermic0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaelbelenki Welcome as contributor 👍

@schneidermic0 schneidermic0 merged commit b184301 into SAP:main Oct 4, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larshp larshp larshp left review comments

@albertmink albertmink albertmink left review comments

@schneidermic0 schneidermic0 schneidermic0 approved these changes

@wurzka wurzka wurzka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@michaelbelenki @albertmink @larshp @schneidermic0 @wurzka