-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Volume mount Support #72
base: main
Are you sure you want to change the base?
Conversation
Quality Gate failedFailed conditions |
An evaluation was done to store service secrets as volume mounts to support credential rotation. But we have the following issues-
Because of these drawbacks, it doesn't make sense to support volume mounts for secrets right now. We will revisit the topic once the above points are resolved. |
@@ -618,8 +647,8 @@ func getContainer(params *DeploymentParameters) []corev1.Container { | |||
ImagePullPolicy: params.WorkloadDetails.DeploymentDefinition.ImagePullPolicy, | |||
Command: params.WorkloadDetails.DeploymentDefinition.Command, | |||
Env: getEnv(params), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to enhance the env in this case to add SERVICE_BINDING_ROOT
in the xsenv scenarios.
enhanced volume & volume mount propogation
Quality Gate failedFailed conditions |
No description provided.