fix: Change focus lock library #764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for fundamental-react ready! Built with commit 08aefa8 |
parostatkiem-zz
changed the title
|
Thanks for the acceptation @jbadan! |
|
@parostatkiem We will merge it, we were waiting to talk with the other fundamental-* libraries so that we stay as consistent as possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change
focus-trap-reactlibrary toreact-focus-lockdue to problems when it was used in Portal.One test was changed because it was performed on the first rendered
<div>.react-focus-lockrenders 3<div>elements (2 helpers and the main one) and the third one is the actual Modal.It looks like people are having similar issues:
focus-trap/focus-trap-react#27
fixes #765