Skip to content

Commit

Permalink
add fixes from the PR review
Browse files Browse the repository at this point in the history
  • Loading branch information
InnaAtanasova committed Nov 8, 2019
1 parent 773a01d commit ca5f7a3
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
4 changes: 3 additions & 1 deletion src/input.scss
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,9 @@ $block: #{$fd-namespace}-input;

&::placeholder {
@include fd-reset();
@include fd-var-color("color", $fd-forms-color--placeholder, --fd-color-neutral-4);

font-style: italic;
color: var(--sapField_PlaceholderTextColor);
}

&--compact {
Expand Down
6 changes: 2 additions & 4 deletions src/mixins/_mixins.scss
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
@import "vars";
// utils
@mixin fd-reset {
font-size: $fd-font-size;
font-size: var(--sapFontSize);
line-height: $fd-line-height;

@include fd-var-color("color", $fd-color, --fd-color-text-1);

color: var(--sapTextColor);
font-family: var(--sapFontFamily);
font-weight: normal;
-webkit-font-smoothing: antialiased;
Expand Down

0 comments on commit ca5f7a3

Please sign in to comment.