Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move collapsed Breadcrumb icon to separate tag #1735

Closed
salarenko opened this issue Sep 30, 2020 · 1 comment · Fixed by #1834
Closed

Move collapsed Breadcrumb icon to separate tag #1735

salarenko opened this issue Sep 30, 2020 · 1 comment · Fixed by #1834
Assignees
@salarenko
Labels
A11y Accessibility concerns or improvements
Milestone
Sprint 49 - Nassau

Comments

@salarenko
Copy link
Contributor

salarenko commented Sep 30, 2020 •
edited
Loading

Describe the bug
A clear and concise description of what the bug is.
Breadcrumb expand collapsed icon should be moved to separate <i> tag and used together with sap-icon class.

Expected behavior

NOW

<span class="fd-breadcrumb__dropdown-icon"></span>

PROPOSED

<i aria-label="Show collapsed breadcrumbs" class="fd-breadcrumb__dropdown-icon sap-icon--slim-arrow-down"></i>
@salarenko salarenko added A11y Accessibility concerns or improvements improvement labels Sep 30, 2020
@salarenko salarenko added this to the Sprint 47 - Bali milestone Sep 30, 2020
@InnaAtanasova
Copy link
Contributor

0.5day

@InnaAtanasova InnaAtanasova removed this from the Sprint 48 - Bora Bora milestone Oct 22, 2020
@InnaAtanasova InnaAtanasova added this to the Sprint 49 - Nassau milestone Oct 26, 2020
@salarenko salarenko mentioned this issue Oct 29, 2020
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@salarenko salarenko

Labels
A11y Accessibility concerns or improvements
Projects
None yet
Milestone
Sprint 49 - Nassau
Development

Successfully merging a pull request may close this issue.

fix: Breadcrumb accessibility improvements + icon as <i> element SAP/fundamental-styles
3 participants
@droshev @salarenko @InnaAtanasova