fix: Breadcrumb accessibility improvements + icon as <i> element #1834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
salarenko
force-pushed
the
fix/1735-breadcrumb-icon
branch
from
3dede76
to
1fa3b15
Compare
|
Deploy preview for fundamental-styles ready! Built with commit 3dede76 |
prsdthkr
changed the title
prsdthkr
approved these changes
Oct 29, 2020
There was a problem hiding this comment.
QA LGTM 🚢
I'm a co-author.
Changes I made:
- keep collapsed breadcrumb navigation menu popover open by default for better screenshot
- move preview-head.html script to a separate file for better debugging
- accessibility improvements to breadcrumb:
- breadcrumb is now a
<nav> - added appropriate aria attributes to the collapsed navigation menu icon, made it behave like a button
- added
aria-current="page"to current breadcrumb item
- breadcrumb is now a
Reference: https://www.w3.org/TR/wai-aria-practices/examples/breadcrumb/index.html
InnaAtanasova
approved these changes
Oct 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes: #1735
Description
This PR:
spantoifd-icon-element-basemixinPlease check whether the PR fulfills the following requirements