Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add storybook visual regression tests to travis #1072

Closed
wants to merge 20 commits into from

Conversation

jbadan
Copy link
Contributor

@jbadan jbadan commented May 29, 2020

Description

Adding storybook visual regression tests to travis

  • updated size to desktop
  • reworked matchThreshold
  • added to travis

@jbadan jbadan requested review from rengare and a team May 29, 2020 17:53
},
width: 1200,
height: 800
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found that these dimensions led to less false failures in travis in fundamental-react

@netlify
Copy link

netlify bot commented May 29, 2020

Deploy preview for fundamental-styles ready!

Built with commit ba78121

https://deploy-preview-1072--fundamental-styles.netlify.app

@jbadan
Copy link
Contributor Author

jbadan commented May 29, 2020

needed prior to #1066

@jbadan jbadan added the WIP label Jun 1, 2020
@jbadan jbadan closed this Jun 1, 2020
@jbadan jbadan deleted the chore/travis2 branch August 27, 2020 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants