feat: Time component html syntax changed to meet a11y criteria #1226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for fundamental-styles ready! Built with commit b7c777b |
rengare
changed the title
InnaAtanasova
changed the title
|
Please update the Wiki |
I did this but It did save. It's fixed now |
InnaAtanasova
approved these changes
Jul 9, 2020
jacobdevera
approved these changes
Jul 9, 2020
rengare
force-pushed
the
feat/1152-changes-made-to-meet-a11y-criteria
branch
from
a097978
to
b7c777b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #1152
Description
PR brings fix for a11y issue.
markup changes:
meridianhas been changedScreenshots
Before:
After:
Please check whether the PR fulfills the following requirements
https://github.com/SAP/fundamental-styles/wiki/PR-Review-Checklist