Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Side Navigation - Refactor icons usage - #2 #1675

Merged
merged 3 commits into from
Sep 22, 2020
Merged

fix: Side Navigation - Refactor icons usage - #2 #1675

merged 3 commits into from
Sep 22, 2020

Conversation

salarenko
Copy link
Contributor

Related Issue

Successor of: #1656
Part of: #1603, #1639

Description

This PR:

  • Styles icon element with icon mixins
  • Adds aria attributes

Before:

<span aria-hidden="true" class="fd-nested-list__icon sap-icon--employee"></span>

After:

<i role="presentation" class="fd-nested-list__icon sap-icon--employee"></i>

Please check whether the PR fulfills the following requirements

@salarenko salarenko added Enhancement New feature or request icons labels Sep 21, 2020
@salarenko salarenko added this to the Sprint 46 - Montreal milestone Sep 21, 2020
@salarenko salarenko requested a review from a team September 21, 2020 10:58
@salarenko salarenko self-assigned this Sep 21, 2020
@netlify
Copy link

netlify bot commented Sep 21, 2020 •
edited
Loading

Deploy preview for fundamental-styles ready!

Built with commit b31d103

https://deploy-preview-1675--fundamental-styles.netlify.app

@JKMarkowski JKMarkowski merged commit 2e3d207 into master Sep 22, 2020
@JKMarkowski JKMarkowski deleted the fix/1603-nested-list branch September 22, 2020 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JKMarkowski JKMarkowski JKMarkowski approved these changes

@InnaAtanasova InnaAtanasova InnaAtanasova approved these changes

Assignees

@salarenko salarenko

Labels
Enhancement New feature or request
Projects
None yet
Milestone
Sprint 46 - Montreal
Development

Successfully merging this pull request may close these issues.
3 participants
@salarenko @JKMarkowski @InnaAtanasova