Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove the css for inline-help #1871

Merged
merged 1 commit into from
Nov 10, 2020

Conversation

InnaAtanasova
Copy link
Contributor

@InnaAtanasova InnaAtanasova commented Nov 9, 2020

Related Issue

Closes #852

Description

Inline-help was removed from the documentation a long time ago. With this PR we remove the scss file which brings the styling of this component. The implementation libraries will compose this component from Popover and Icon.

BREAKING CHANGE:

  • Remove Inline Help from the library

Documentation

  • Breaking Changes wiki has been updated in case of breaking changes.

@InnaAtanasova InnaAtanasova added this to the Sprint 50 - Tulum milestone Nov 9, 2020
@InnaAtanasova InnaAtanasova requested a review from a team November 9, 2020 19:30
@InnaAtanasova InnaAtanasova self-assigned this Nov 9, 2020
@netlify
Copy link

netlify bot commented Nov 9, 2020

Deploy preview for fundamental-styles ready!

Built with commit 42593bb

https://deploy-preview-1871--fundamental-styles.netlify.app

Copy link
Contributor

@jbadan jbadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎗️ Remember to merge with BREAKING CHANGE: in the description box

@droshev droshev self-requested a review November 10, 2020 17:20
@InnaAtanasova InnaAtanasova merged commit 3c20d06 into master Nov 10, 2020
@InnaAtanasova InnaAtanasova deleted the fix/remove-inline-help-scss branch November 10, 2020 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

List Enhancement - Navigation Indication
3 participants