Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: forms refactoring #419

Merged
merged 7 commits into from
Nov 13, 2019
Merged

feat: forms refactoring #419

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
155ceb5
forms refactoring
InnaAtanasova Nov 5, 2019
58f413e
add checkbox and textarea refactoring
InnaAtanasova Nov 7, 2019
8116c6e
add test templates
InnaAtanasova Nov 7, 2019
773a01d
add visual regression tests
InnaAtanasova Nov 7, 2019
ca5f7a3
add fixes from the PR review
InnaAtanasova Nov 8, 2019
0ebd397
test updates
InnaAtanasova Nov 8, 2019
6a90a95
fix the toggle
InnaAtanasova Nov 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/_sass/_docs-display-component.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@

> .fd-tile__content {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think those stylings should be even removed. They create false expectations

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This rule is applied only when the fd-tile is child of .docs-component.
The padding is just for the content to look nice and the width is to show the cases when we have very long text and truncation.
We want to be able to see this:
Screen Shot 2019-11-08 at 10 52 21 AM

Without the width we see this:
Screen Shot 2019-11-08 at 10 53 57 AM

padding: 60px 20px;
overflow: visible;
width: 100%;
}

> p {
Expand Down
35 changes: 35 additions & 0 deletions docs/js/customscripts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,41 @@ $(document).ready(function () {
triStateCheckbox.indeterminate = true;
}

const triStateCheckboxI1 = document.getElementById('Ai4ez613i1');
if (triStateCheckboxI1) {
triStateCheckboxI1.indeterminate = true;
}

const triStateCheckboxI2 = document.getElementById('Ai4ez613i2');
if (triStateCheckboxI2) {
triStateCheckboxI2.indeterminate = true;
}

const triStateCheckboxI3 = document.getElementById('Ai4ez613i3');
if (triStateCheckboxI3) {
triStateCheckboxI3.indeterminate = true;
}

const triStateCheckboxI4 = document.getElementById('Ai4ez613i4');
if (triStateCheckboxI4) {
triStateCheckboxI4.indeterminate = true;
}

const triStateCheckboxI5 = document.getElementById('Ai4ez613i5');
if (triStateCheckboxI5) {
triStateCheckboxI5.indeterminate = true;
}

const triStateCheckboxI6 = document.getElementById('Ai4ez613i6');
if (triStateCheckboxI6) {
triStateCheckboxI6.indeterminate = true;
}

const triStateCheckboxI7 = document.getElementById('Ai4ez613i7');
if (triStateCheckboxI7) {
triStateCheckboxI7.indeterminate = true;
}

// display responsive component controls
const displayControls = document.querySelectorAll('.docs-component--responsive-display__controls');
displayControls.forEach((displayControl) => {
Expand Down
Loading