Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature - whitesourceExecuteScan - adding ability to scan multiple docker images #4755

Merged
merged 4 commits into from
Jan 5, 2024
Merged

Feature - whitesourceExecuteScan - adding ability to scan multiple docker images #4755

merged 4 commits into from
Jan 5, 2024

Conversation

dimaste
Copy link
Member

@dimaste dimaste commented Jan 2, 2024

Changes

  • Tests
  • Documentation

@dimaste dimaste requested a review from a team as a code owner January 2, 2024 13:25
loewenstein
loewenstein reviewed Jan 2, 2024
View reviewed changes
resources/metadata/whitesourceExecuteScan.yaml
@@ -377,6 +377,25 @@ spec:
- PARAMETERS
- STAGES
- STEPS
- name: scanImages
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we consider to take the images to scan from the common pipeline environment?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be the next step of this. The first pilot of this will be implemented for Black Duck detect.
For now it's just a workaround for some specific cases

@sumeetpatil
Copy link
Member

/it

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@sumeetpatil
Copy link
Member

/it-go

@dimaste dimaste merged commit 6cc6a4e into master Jan 5, 2024
12 checks passed
@dimaste dimaste deleted the add-multiple-image-scan-feature-for-mendscan branch January 5, 2024 15:23
@radianer radianer mentioned this pull request Jan 8, 2024
Closed
@fschmi
Copy link

fschmi commented Jan 9, 2024 •
edited
Loading

FYI, this implementation is not backward compatible. I my case, I was using the scanImage parameter explicitly. However, since scanImages defaults container/imageNameTags it will now choose those values, rather than the one that I explicitly defined.
I would have preferred an implementation that checks if scanImage is explicitly defined before running this logic.

It also seems like this implementation, in general, no longer supports the scanImage parameter in favor of scanImages. You should update the documentation (or code) accordingly

maxatsap pushed a commit to maxatsap/jenkins-library that referenced this pull request Jul 23, 2024
@dimaste @maxatsap
Feature - whitesourceExecuteScan - adding ability to scan multiple do…
fa769cd 
…cker images (SAP#4755)

* added-multiple-images-scan-logic

* amended-description

* added-reference-to-common-pipeline-env
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@loewenstein loewenstein loewenstein left review comments

@akram8008 akram8008 akram8008 approved these changes

@andrew-kireev andrew-kireev andrew-kireev approved these changes

@sumeetpatil sumeetpatil Awaiting requested review from sumeetpatil

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@dimaste @sumeetpatil @fschmi @loewenstein @andrew-kireev @akram8008