-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add namespaces to annotation template #2452
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: 0f2d01f The changes in this PR will be included in the next version bump. This PR includes changesets to release 17 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
…hub.com/SAP/open-ux-tools into feat/add-annotation-template-namespaces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes looks good. Annotation file are written with namespace and alias
…-template-namespaces' into feat/add-annotation-template-namespaces
…-template-namespaces' into feat/add-annotation-template-namespaces
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed changes in adp-tooling and create package
Changes looks good for fetching metadata and finding namespace
Tested with app in playground - Generated annotation file is now compliant and can annotate targets.
Test coverage good.
Need to align
Whether subfolder in changes folder required for annotation change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed changes to odata-service-writer
.
This looks fine. Thanks.
Changset ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- code looks good
- great coverage
- not tested manually
@Jimmy-Joseph19 as we discussed, the manifest changes will no longer be stored under the |
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mmilko01,
- focused my review on create module, changes look good
- changeset exists
- test coverage is great
- did a visual review, no manual test
Approvde from my side.
#2549
@sap-ux/adp-tooling
to fetch $metadata for a given Data Source@sap-ux/adp-tooling
writing logic to render the new templatesap-ux add annotations
CLI implementationsap-ux add annotations
to be based on the merged descriptor and not the base descriptor