Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add namespaces to annotation template #2452

Open
wants to merge 41 commits into
base: main
Choose a base branch
from

Conversation

mmilko01
Copy link
Contributor

@mmilko01 mmilko01 commented Oct 10, 2024

#2549

  • Extends current Annotation XML template
  • Enhances @sap-ux/adp-tooling to fetch $metadata for a given Data Source
  • Extends @sap-ux/adp-tooling writing logic to render the new template
  • Consumes the new functionality on sap-ux add annotations CLI implementation
  • Extends the sap-ux add annotations to be based on the merged descriptor and not the base descriptor

Copy link

changeset-bot bot commented Oct 10, 2024

🦋 Changeset detected

Latest commit: 0f2d01f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 17 packages
Name Type
@sap-ux/adp-tooling Patch
@sap-ux/axios-extension Patch
@sap-ux/create Patch
@sap-ux/odata-service-writer Patch
@sap-ux/preview-middleware Patch
@sap-ux/abap-deploy-config-inquirer Patch
@sap-ux/app-config-writer Patch
@sap-ux/backend-proxy-middleware Patch
@sap-ux/deploy-tooling Patch
@sap-ux/environment-check Patch
@sap-ux/odata-service-inquirer Patch
@sap-ux/system-access Patch
@sap-ux/odata-cli Patch
@sap-ux/generator-simple-fe Patch
@sap-ux/fiori-elements-writer Patch
@sap-ux/fiori-freestyle-writer Patch
@sap-ux/abap-deploy-config-writer Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Jimmy-Joseph19
Jimmy-Joseph19 previously approved these changes Oct 30, 2024
Copy link
Contributor

@Jimmy-Joseph19 Jimmy-Joseph19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good. Annotation file are written with namespace and alias

@mmilko01 mmilko01 marked this pull request as ready for review November 8, 2024 20:40
@mmilko01 mmilko01 requested review from a team as code owners November 8, 2024 20:40
@mmilko01 mmilko01 added adp-tooling feature New feature or request odata-service-writer @sap-ux/odata-servier-writer create @sap-ux/create labels Nov 13, 2024
Copy link
Contributor

@Jimmy-Joseph19 Jimmy-Joseph19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed changes in adp-tooling and create package
Changes looks good for fetching metadata and finding namespace
Tested with app in playground - Generated annotation file is now compliant and can annotate targets.
Test coverage good.

Need to align
Whether subfolder in changes folder required for annotation change?

Copy link
Member

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed changes to odata-service-writer.
This looks fine. Thanks.
Changset ✅

Copy link
Contributor

@testojs testojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • code looks good
  • great coverage
  • not tested manually

@mmilko01
Copy link
Contributor Author

mmilko01 commented Nov 15, 2024

@Jimmy-Joseph19 as we discussed, the manifest changes will no longer be stored under the /manifest subfolder, but under /changes subfolder. This will be introduced as a new PR for all types of manifest changes. Also, the new structure will be applied for newly created projects and the old structure would still need to be supported for old projects.

Copy link

sonarcloud bot commented Nov 15, 2024

Copy link
Contributor

@Klaus-Keller Klaus-Keller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mmilko01,

  • focused my review on create module, changes look good
  • changeset exists
  • test coverage is great
  • did a visual review, no manual test

Approvde from my side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adp-tooling create @sap-ux/create feature New feature or request odata-service-writer @sap-ux/odata-servier-writer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants