Merge 6dc9f77 into 6eb3258

SAP · Oct 10, 2024 · d451df5 · d451df5
2 parents 6eb3258 + 6dc9f77
commit d451df5
Show file tree

Hide file tree

Showing 4 changed files with 29 additions and 1 deletion.
diff --git a/feature-libs/cart/base/components/added-to-cart-dialog/added-to-cart-dialog.component.html b/feature-libs/cart/base/components/added-to-cart-dialog/added-to-cart-dialog.component.html
@@ -13,7 +13,27 @@
       aria-atomic="true"
       class="cx-dialog-header modal-header"
     >
-      <div id="dialogTitle" class="cx-dialog-title modal-title">
+      <div
+        *cxFeature="'a11yUpdatingCartNoNarration'"
+        id="dialogTitle"
+        class="cx-dialog-title modal-title"
+      >
+        <span *ngIf="loaded$ | async">
+          {{
+            (addedEntryWasMerged$ | async)
+              ? ('addToCart.itemsIncrementedInYourCart' | cxTranslate)
+              : ('addToCart.itemsAddedToYourCart' | cxTranslate)
+          }}
+        </span>
+        <span *ngIf="!(loaded$ | async)" aria-hidden="true">
+          {{ 'addToCart.updatingCart' | cxTranslate }}
+        </span>
+      </div>
+      <div
+        *cxFeature="'!a11yUpdatingCartNoNarration'"
+        id="dialogTitle"
+        class="cx-dialog-title modal-title"
+      >
         {{
           (loaded$ | async)
             ? (addedEntryWasMerged$ | async)

diff --git a/feature-libs/cart/base/components/added-to-cart-dialog/added-to-cart-dialog.component.ts b/feature-libs/cart/base/components/added-to-cart-dialog/added-to-cart-dialog.component.ts
@@ -95,6 +95,7 @@ export class AddedToCartDialogComponent implements OnInit, OnDestroy {
   ) {
     useFeatureStyles('a11yExpandedFocusIndicator');
     useFeatureStyles('a11yPreventHorizontalScroll');
+    useFeatureStyles('a11yUpdatingCartNoNarration');
   }
 
   ngOnInit(): void {

diff --git a/projects/core/src/features-config/feature-toggles/config/feature-toggles.ts b/projects/core/src/features-config/feature-toggles/config/feature-toggles.ts
@@ -576,6 +576,11 @@ export interface FeatureTogglesInterface {
    */
   a11ySearchBoxFocusOnEscape?: boolean;
 
+  /**
+   * In `AddedToCartDialogComponent`, `Updating cart...` should no longer read by a screen reader.
+   */
+  a11yUpdatingCartNoNarration?: boolean;
+
   /**
    * In OCC cart requests, it puts parameters of a cart name and cart description
    * into a request body, instead of query params.
@@ -718,6 +723,7 @@ export const defaultFeatureToggles: Required<FeatureTogglesInterface> = {
   a11yDialogTriggerRefocus: false,
   a11yAddToWishlistFocus: false,
   a11ySearchBoxFocusOnEscape: false,
+  a11yUpdatingCartNoNarration: false,
   occCartNameAndDescriptionInHttpRequestBody: false,
   cmsBottomHeaderSlotUsingFlexStyles: false,
   useSiteThemeService: false,

diff --git a/projects/storefrontapp/src/app/spartacus/spartacus-features.module.ts b/projects/storefrontapp/src/app/spartacus/spartacus-features.module.ts
@@ -375,6 +375,7 @@ if (environment.cpq) {
         a11yDialogTriggerRefocus: true,
         a11yAddToWishlistFocus: true,
         a11ySearchBoxFocusOnEscape: true,
+        a11yUpdatingCartNoNarration: true,
         cmsBottomHeaderSlotUsingFlexStyles: true,
         useSiteThemeService: false,
         enableConsecutiveCharactersPasswordRequirement: true,