Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a11y tab component to plp facets #19244

Draft
wants to merge 91 commits into
base: develop
Choose a base branch
from
Draft

Conversation

Zeyber
Copy link
Contributor

@Zeyber Zeyber commented Sep 16, 2024

No description provided.

@Zeyber Zeyber requested a review from a team as a code owner September 16, 2024 09:35
Base automatically changed from feature/GH-11637-pdp to develop September 26, 2024 07:02
@github-actions github-actions bot marked this pull request as draft September 30, 2024 07:52
@Zeyber
Copy link
Contributor Author

Zeyber commented Oct 2, 2024

Note: Best to recheck attributes on tab paragraph component are correct as collapse showed a value of [Object] in a demo.

@Zeyber Zeyber marked this pull request as ready for review October 7, 2024 06:27
Copy link
Contributor

github-actions bot commented Oct 7, 2024

Merge Checks Failed

Please push a commit to re-trigger the build. 
To push an empty commit you can use `git commit --allow-empty -m "Trigger Build"`

@developpeurweb
Copy link
Contributor

@Zeyber so far so good, the only thing that I noticed is that two Tab key strokes are needed to get into the content panel, auditors have complained about that in other components.
Is it possible to go to the first option in the panel on the first stroke but without losing the items count for the group? So, perhaps move the aria-label with the group's items count to the collapsible button.

@github-actions github-actions bot marked this pull request as draft October 9, 2024 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants