fix: (CXSPA-7948) add aria-labelledby to quantity input #19312
+9
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
StanislavSukhanov
commented
Oct 1, 2024
StanislavSukhanov
commented
- closes: https://jira.tools.sap/browse/CXSPA-7948
spartacus
|
||||||||||||||||||||||||||
| Project |
spartacus
|
| Run status |
|
| Run duration | 11m 21s |
| Commit |
|
| Committer | Stanislav Sukhanov |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
3
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
125
|
Upgrade your plan to view test results. | |
Pio-Bar
previously approved these changes
Oct 1, 2024
Zeyber
previously approved these changes
Oct 2, 2024
developpeurweb
requested changes
Oct 9, 2024
There was a problem hiding this comment.
@StanislavSukhanov this didn't work for me on JAWS. Can you please try with aria-describedby and associate it to the input field.
As per screenshot, I emulated it with the Chrome inspector and it seems to work well without interfering with the aria-label.
* add support to pass an id of an element you want to associate ItemCounterComponent's number input, so it gets narrated by a screen reader. * https://jira.tools.sap/browse/CXSPA-7948
StanislavSukhanov
dismissed stale reviews from Zeyber and Pio-Bar
via
d9c7635
StanislavSukhanov
force-pushed
the
feature/7948-add-aria-labelledby-to-quantity-input
branch
from
4406540
to
d9c7635
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.