fix: (CXSPA-7997) - Change "QTY" into "Quantity" #19339
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spartacus
|
||||||||||||||||||||||||||
| Project |
spartacus
|
| Run status |
|
| Run duration | 11m 45s |
| Commit |
|
| Committer | petarmarkov9449 |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
4
|
Pending
|
2
|
Skipped
|
0
|
Passing
|
125
|
Upgrade your plan to view test results. | |
Pio-Bar
previously approved these changes
Oct 7, 2024
Zeyber
requested changes
Oct 8, 2024
| @@ -9,7 +9,7 @@ | |||
| "description": "Description", | |||
| "item": "Item", | |||
| "itemPrice": "Item price", | |||
| "quantity": "Qty", | |||
| "quantity": "Quantity", | |||
There was a problem hiding this comment.
We should be careful about changing or removing properties already in use due to breaking changes (even translations).
Lets create a new property for "Quantity" to avoid making the breaking change and hide any use of the translation behind a feature toggle. You can do this in either the template or the service. It is similar to how you have already done with styles.
In template example:
// feature off
<ng-container *cxFeature="'!a11yQTY2Quantity'">
// show old content or translation
...
// feature on
<ng-container *cxFeature="'a11yQTY2Quantity'">
// show new
In service:
someMethod() {
...
if( this.featureConfigService.isEnabled('a11yQTY2Quantity') {
// Do something when feature flag is enabled
}
...
}
There was a problem hiding this comment.
I've updated it.
Zeyber
approved these changes
Oct 10, 2024
|
Hey @petarmarkov9449, I still see "Qty", can you please make sure the Feature Flag is enabled. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: CXSPA-7997
Change "QTY" into "Quantity"