fix percentage issue #19345
Draft
fix percentage issue #19345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vigneshkrish8691
approved these changes
Oct 9, 2024
...libs/cpq-quote/cpq-quote-discount/components/cpq-quote-discount-tbody/cpq-quote.component.ts
Show resolved
Hide resolved
| const discountAmount = (basePrice * discountPercentage) / 100; | ||
| return basePrice - discountAmount; | ||
| if ( | ||
| basePrice !== undefined && |
There was a problem hiding this comment.
Baseprice you are already doing a null check when the function is called do you thing undefined is needed?
| @@ -52,11 +52,18 @@ export class CpqQuoteDiscountComponent implements OnInit, OnDestroy { | |||
| } | |||
| getDiscountedPrice( | |||
| basePrice: number | undefined, | |||
There was a problem hiding this comment.
Should the price be of type number, or can it be of any other type?
| @@ -45,4 +45,24 @@ export class CpqQuoteOfferComponent implements OnInit, OnDestroy { | |||
| this.subscription.unsubscribe(); | |||
| } | |||
| } | |||
| getDiscountPercentage( | |||
There was a problem hiding this comment.
Why are there two identical functions in both the cpq-quote-component and the offer-component? What is the difference between them? Why cant we make use of the same?
There was a problem hiding this comment.
In the cpq-offer-component, the getDiscountPercentage function calculates the discount percentage, while in the cpq-quote-component, the getDiscountedPrice function calculates the discount on per-item basis.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.tools.sap/browse/CXSPA-8479