chore(schematics/testing.ts): restore previous @spartacus:registry instead of hardcoded NPM registry on the process exit
#19378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…instead of hardcoded NPM registry on the process exit
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
pawelfras
approved these changes
Oct 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, on the process exit, the value of
@spartacus:registryis restored to the outdated URL of public NPM registryhttps://registry.npmjs.org/. It was useful only until we stopped releasing to public NPM many months ago. Now it's confusing and a bit annoying. It's because you'd rather like it to be restored to a previous real registry url, e.g. RBSC.To fix it, now we remember the used
@spartacus:registrybefore running the scriptschematics/testing.ts. Then the scrip overwrites@spartacus:registryto verdaccio URL (as it does usually). And then on the process exit we restore the remembered URL original URL. ... which should improve DX while re-running this script multiple times.closes https://jira.tools.sap/browse/CXSPA-8636