Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(provisioning)!: change to the new div provisioning api #93

Merged
merged 11 commits into from
Oct 8, 2024

Conversation

Phil91
Copy link
Collaborator

@Phil91 Phil91 commented Sep 12, 2024

Description

Change the process of creating the wallet and subscriptions to the new div provisioning api

Why

To slimline the process

Issue

Refs: #79

Checklist

  • I have performed a self-review of my own code
  • I have successfully tested my changes locally
  • I have added tests that prove my changes work
  • I have checked that new and existing tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas
  • I have added copyright and license headers, footers (for .md files) or files (for images)

@Phil91 Phil91 added the enhancement New feature or request label Sep 12, 2024
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 20 potential problems in the proposed changes. Check the Files changed tab for more details.

tests/clients/Dim.Clients.Tests/ProvisioningClientTests.cs Dismissed Show dismissed Hide dismissed
tests/clients/Dim.Clients.Tests/ProvisioningClientTests.cs Dismissed Show dismissed Hide dismissed
tests/clients/Dim.Clients.Tests/ProvisioningClientTests.cs Dismissed Show dismissed Hide dismissed
tests/clients/Dim.Clients.Tests/ProvisioningClientTests.cs Dismissed Show dismissed Hide dismissed
tests/clients/Dim.Clients.Tests/ProvisioningClientTests.cs Dismissed Show dismissed Hide dismissed
tests/clients/Dim.Clients.Tests/ProvisioningClientTests.cs Dismissed Show dismissed Hide dismissed
tests/clients/Dim.Clients.Tests/ProvisioningClientTests.cs Dismissed Show dismissed Hide dismissed
@Phil91 Phil91 force-pushed the feature/79-div-provisioning branch 5 times, most recently from 403d553 to 344983b Compare October 1, 2024 07:29
@Phil91 Phil91 changed the title feat(provisioning): change to the new div provisioning api feat(provisioning)!: change to the new div provisioning api Oct 1, 2024
@Phil91 Phil91 force-pushed the feature/79-div-provisioning branch from 1f43174 to 2a61a8a Compare October 1, 2024 13:16
@Phil91 Phil91 merged commit bf650d4 into main Oct 8, 2024
8 checks passed
@Phil91 Phil91 deleted the feature/79-div-provisioning branch October 8, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants