Skip to content

Commit

Permalink
[INTERNAL] Fix logger-related tests
Browse files Browse the repository at this point in the history
SAP/ui5-logger#363 made logger modules more
restrictive.

* XMLCompositeAnalyzer must provide a module name to create a logger
  instance
* generateLibraryPreload integration tests need to be executed in
  sequence to prevent issues with the stateful BuildLogger
  • Loading branch information
RandomByte committed Jan 19, 2023
1 parent 755df0f commit bb4b09d
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion test/lib/lbt/analyzer/XMLCompositeAnalyzer.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import XMLCompositeAnalyzer from "../../../../lib/lbt/analyzer/XMLCompositeAnaly
import ModuleInfo from "../../../../lib/lbt/resources/ModuleInfo.js";
import sinonGlobal from "sinon";
import logger from "@ui5/logger";
const loggerInstance = logger.getLogger();
const loggerInstance = logger.getLogger("XMLCompositeAnalyzerTest");
import esmock from "esmock";

test.beforeEach((t) => {
Expand Down
8 changes: 4 additions & 4 deletions test/lib/tasks/bundlers/generateLibraryPreload.integration.js
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ const findFiles = (folder) => {
});
};

test("integration: build library.d with library preload", async (t) => {
test.serial("integration: build library.d with library preload", async (t) => {
const destPath = "./test/tmp/build/library.d/preload";
const expectedPath = "./test/expected/build/library.d/preload";
const excludedTasks = ["*"];
Expand Down Expand Up @@ -82,7 +82,7 @@ const libraryDTree = {
}
};

test("integration: build sap.ui.core with library preload", async (t) => {
test.serial("integration: build sap.ui.core with library preload", async (t) => {
const destPath = "./test/tmp/build/sap.ui.core/preload";
const expectedPath = "./test/expected/build/sap.ui.core/preload";
const excludedTasks = ["*"];
Expand Down Expand Up @@ -135,7 +135,7 @@ const sapUiCoreTree = {
};


test("integration: generateLibraryPreload", async (t) => {
test.serial("integration: generateLibraryPreload", async (t) => {
const reader = createAdapter({
virBasePath: "/"
});
Expand Down Expand Up @@ -181,7 +181,7 @@ test("integration: generateLibraryPreload", async (t) => {
}, "Source map file should have valid JSON content");
});

test("integration: generateLibraryPreload with designtime and support files", async (t) => {
test.serial("integration: generateLibraryPreload with designtime and support files", async (t) => {
const reader = createAdapter({
virBasePath: "/"
});
Expand Down

0 comments on commit bb4b09d

Please sign in to comment.