Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INTERNAL] Replace deprecated new Buffer() calls #1043

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Conversation

RandomByte
Copy link
Member

Replacing deprecated 'new Buffer(string)' with 'Buffer.from(string)'.

Resolves a TypeError being thrown in our tests when executed with
Node 20.15.0 or 22.3.0.

Root cause: nodejs/node#53075

Replacing deprecated 'new Buffer(string)' with 'Buffer.from(string)'.

Resolves a TypeError being thrown in our tests when executed with
Node 20.15.0 or 22.3.0.

Root cause: nodejs/node#53075
@RandomByte RandomByte requested a review from a team July 2, 2024 08:26
@coveralls
Copy link

Coverage Status

coverage: 94.668% (+0.08%) from 94.588%
when pulling 328a63c on remove-new-buffer
into f119ccd on main.

@RandomByte RandomByte merged commit 934956a into main Jul 2, 2024
17 checks passed
@RandomByte RandomByte deleted the remove-new-buffer branch July 2, 2024 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants