Skip to content

Commit

Permalink
[BREAKING] Rename ui5HomeDir to ui5DataDir in APIs (#687)
Browse files Browse the repository at this point in the history
BREAKING CHANGE:
`@ui5/project`'s Installers' and Resolvers' argument `ui5HomeDir` is now
renamed to `ui5DataDir`

JIRA: CPOUI5FOUNDATION-802
Relates to: SAP/ui5-tooling#701
Depends on: SAP/ui5-project#707
  • Loading branch information
d3xter666 authored Feb 29, 2024
1 parent 6a8c7a6 commit 772ac29
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions lib/framework/utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -37,15 +37,15 @@ export async function createFrameworkResolverInstance({frameworkName, frameworkV
return new Resolver({
cwd,
version: frameworkVersion,
ui5HomeDir: await utils.getUi5DataDir({cwd})
ui5DataDir: await utils.getUi5DataDir({cwd})
});
}

export async function frameworkResolverResolveVersion({frameworkName, frameworkVersion}, {cwd}) {
const Resolver = await utils.getFrameworkResolver(frameworkName, frameworkVersion);
return Resolver.resolveVersion(frameworkVersion, {
cwd,
ui5HomeDir: await utils.getUi5DataDir({cwd})
ui5DataDir: await utils.getUi5DataDir({cwd})
});
}

Expand Down
6 changes: 3 additions & 3 deletions test/lib/framework/utils.js
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ test.serial("createFrameworkResolverInstance: Without ui5DataDir", async (t) =>
{
cwd: "my-project-path",
version: "<framework-version>",
ui5HomeDir: undefined
ui5DataDir: undefined
}
]);
});
Expand Down Expand Up @@ -217,7 +217,7 @@ test.serial("createFrameworkResolverInstance: With ui5DataDir", async (t) => {
{
cwd: "my-project-path",
version: "<framework-version>",
ui5HomeDir: "my-ui5-data-dir"
ui5DataDir: "my-ui5-data-dir"
}
]);
});
Expand Down Expand Up @@ -246,7 +246,7 @@ test.serial("frameworkResolverResolveVersion", async (t) => {
"latest",
{
cwd: "my-project-path",
ui5HomeDir: undefined
ui5DataDir: undefined
}
]);
});
Expand Down

0 comments on commit 772ac29

Please sign in to comment.