[FIX] ui5 config: Allow usage of all Configuration options #645
+67
−63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomByte
previously approved these changes
Aug 18, 2023
Options are now properly read from the @ui5/project Configuration class in order to be decoupled from future changes. Some code could be removed as the checks are done via yargs. See: SAP/ui5-project#642
Co-authored-by: Merlin Beutlberger <[email protected]>
matz3
force-pushed
the
improve-config-command
branch
from
6a35ec9
to
6716d10
Compare
RandomByte
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Options are now properly read from the @ui5/project Configuration class
in order to be decoupled from future changes.
Some code could be removed as the checks are done via yargs.
See: SAP/ui5-project#642
JIRA: CPOUI5FOUNDATION-716