[BREAKING] Replace npmlog with @ui5/logger/Logger #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RandomByte
force-pushed
the
logger-v3
branch
3 times, most recently
from
62e6ab6
to
01cac47
Compare
Remove the usage of npmlog and refactor @ui5/logger moduels to emit log events which are then catched in dedicated handlers. This is somewhat inspired by npm's proc-log module. Internally, there are additional logger-classes for certain use cases. Like updating status information on start/end of a project or -task build. This allows handlers to reate metrics on the build progress and, for example, render a progress bar. All of this should make @ui5/logger more future-proof. Thanks to the decoupling of log-message creation and -handling, multiple intances and versions of @ui5/logger can interoperate with each other.
RandomByte
force-pushed
the
logger-v3
branch
2 times, most recently
from
ea11147
to
d07b33a
Compare
flovogt
requested changes
Jan 17, 2023
flovogt
approved these changes
Jan 17, 2023
RandomByte
added a commit
to SAP/ui5-project
that referenced
this pull request
Jan 17, 2023
RandomByte
added a commit
to SAP/ui5-cli
that referenced
this pull request
Jan 17, 2023
RandomByte
added a commit
to SAP/ui5-project
that referenced
this pull request
Jan 17, 2023
RandomByte
added a commit
to SAP/ui5-cli
that referenced
this pull request
Jan 17, 2023
RandomByte
added a commit
to SAP/ui5-project
that referenced
this pull request
Jan 17, 2023
This was referenced Jan 17, 2023
RandomByte
added a commit
to SAP/ui5-builder
that referenced
this pull request
Jan 17, 2023
SAP/ui5-logger#363 made logger modules more restrictive. * XMLCompositeAnalyzer must provide a module name to create a logger instance * generateLibraryPreload integration tests need to be executed in sequence to prevent issues with the stateful BuildLogger
RandomByte
added a commit
to SAP/ui5-project
that referenced
this pull request
Jan 18, 2023
RandomByte
added a commit
to SAP/ui5-cli
that referenced
this pull request
Jan 18, 2023
RandomByte
added a commit
to SAP/ui5-project
that referenced
this pull request
Jan 19, 2023
RandomByte
added a commit
to SAP/ui5-cli
that referenced
this pull request
Jan 19, 2023
RandomByte
added a commit
to SAP/ui5-cli
that referenced
this pull request
Jan 19, 2023
RandomByte
added a commit
to SAP/ui5-builder
that referenced
this pull request
Jan 19, 2023
SAP/ui5-logger#363 made logger modules more restrictive. * XMLCompositeAnalyzer must provide a module name to create a logger instance * generateLibraryPreload integration tests need to be executed in sequence to prevent issues with the stateful BuildLogger
d3xter666
pushed a commit
to SAP/ui5-project
that referenced
this pull request
Feb 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the usage of npmlog and refactor @ui5/logger modules to emit log
events which are then caught in dedicated handlers. This is somewhat
inspired by npm's proc-log module.
Internally, there are additional logger-classes for certain use cases.
Like updating status information on start/end of a project or -task
build. This allows handlers to create metrics on the build progress and,
for example, render a progress bar.
All of this should make @ui5/logger more future-proof. Thanks to the
decoupling of log-message creation and -handling, multiple instances and
versions of @ui5/logger can interoperate with each other.
BREAKING CHANGE:
This version of @ui5/logger is not compatible with previous versions. For example, messages logged through version 2 might disturb the progress bar rendering of this version. Future version updates however are expected to be compatible.
JIRA: CPOUI5FOUNDATION-603