-
Notifications
You must be signed in to change notification settings - Fork 7
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[INTERNAL] Fix jquery plugin comment
jquery plugin imports are added as dependency with a comment. This comment was a line comment which could break the code during re-formatting. Therefore the comment was changed to a block comment which cannot break the code during re-formatting. Fixes: #29
- Loading branch information
1 parent
6caf0e7
commit 21fca37
Showing
7 changed files
with
75 additions
and
3 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 changes: 27 additions & 0 deletions
27
test/addMissingDependencies/jquery-plugin-addAriaLabelledBy.config.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
{ | ||
"modules": { | ||
"jQuery Function Extensions": { | ||
"*.addAriaLabelledBy": { | ||
"newModulePath": "sap/ui/dom/jquery/Aria", | ||
"replacer": "AddComment", | ||
"commentText": " jQuery Plugin \"addAriaLabelledBy\"", | ||
"finder": "JQueryFunctionExtensionFinderWithDependencyCheck", | ||
"extender": "AddUnusedImportWithComment", | ||
"version": "^1.58.0" | ||
} | ||
} | ||
}, | ||
"finders": { | ||
"JQueryFunctionExtensionFinderWithDependencyCheck": "tasks/helpers/finders/JQueryFunctionExtensionFinderWithDependencyCheck.js" | ||
}, | ||
"extenders": { | ||
"AddUnusedImportWithComment": "tasks/helpers/extenders/AddUnusedImportWithComment.js" | ||
}, | ||
"replacers": { | ||
"AddComment": "tasks/helpers/replacers/AddComment.js" | ||
}, | ||
"comments": { | ||
"unhandledReplacementComment": "TODO unhandled replacement" | ||
}, | ||
"excludes": [] | ||
} |
15 changes: 15 additions & 0 deletions
15
test/addMissingDependencies/jquery-plugin-addAriaLabelledBy.expected.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,15 @@ | ||
sap.ui.define([ | ||
"./library", | ||
'sap/ui/core/Core', | ||
"sap/ui/core/Item", | ||
'sap/ui/core/Icon', | ||
'sap/ui/core/IconPool', | ||
/* jQuery Plugin "addAriaLabelledBy"*/ | ||
"sap/ui/dom/jquery/Aria" | ||
], | ||
function(library, Core, Item, Icon, IconPool) { | ||
"use strict"; | ||
|
||
// jQuery Plugin "addAriaLabelledBy" | ||
return $a.addAriaLabelledBy(""); | ||
}); |
6 changes: 6 additions & 0 deletions
6
test/addMissingDependencies/jquery-plugin-addAriaLabelledBy.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
sap.ui.define(["./library", 'sap/ui/core/Core', "sap/ui/core/Item", 'sap/ui/core/Icon', 'sap/ui/core/IconPool'], | ||
function(library, Core, Item, Icon, IconPool) { | ||
"use strict"; | ||
|
||
return $a.addAriaLabelledBy(""); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters