Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE][WIP] Add replacer for jQuery.sap.extend #57

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

devtomtom
Copy link
Member

Still WIP...

@tobiasso85
Copy link
Contributor

There are many ways to solve this.

  1. enhance replaceGlobals to be able to change the dependencies dynamically after the replacement. But changing this rather static logic requires quite some thoughts
  2. Use addMissingDependencies with custom finder, replacer and extender (dynamic dependency decision in replacer).
  3. Use addMissingDependencies with custom finder, replacer and extender (dynamic dependency decision in replacer, config passed then to extender).
  4. Use addMissingDependencies with custom finder, replacer and extender (dynamic dependency decision in finder, specific replacer for each decision with extender).

Slide3
Slide4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants