-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"project?.getPropertiesFileSourceEncoding is not a function" after upgrading to v3 #800
Comments
Hi @Zitruism, |
@flovogt this is also not possible for theme-library and module, as such you should at least ensure that the server code does not break if the method is not available. |
@nlunets Thanks for pointing that out. PR SAP/ui5-server#584 is doing so. |
Fixed with @ui5/[email protected] |
Expected Behavior
When running
ui5 serve
, I should be able to load .properties files which are contained inside a project-shim. With UI5 tooling v2 this worked just fine.Current Behavior
With UI5 tooling v3, loading of .properties files which are part of a project-shim (a npm module) cause an internal server error with the error message stating that "project?.getPropertiesFileSourceEncoding is not a function"
Steps to Reproduce the Issue
ui5 serve
lib/myPackage
directory and open a .properties file thats contained inside the directory.Context
ui5 --version
when using the CLI):3.0.4
18.15.0
9.5.0
Windows 11 Pro 64Bit
Log Output / Stack Trace
I took a look at the code and this is the part where the error is thrown:
It seems the project object which is retrieved by the requested .properties resource does indeed not posess a getPropertiesFileSourceEncoding function.
The text was updated successfully, but these errors were encountered: