Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isbinaryfile does not follow semver for supported node, use fixed version #241

Merged
merged 3 commits into from
Mar 27, 2024

Conversation

mshima
Copy link
Collaborator

@mshima mshima commented Mar 27, 2024

Use fixed version to avoid conflicts in the future

node v14 and v16 support were dropped in a patch version.

@mshima mshima changed the title isbinaryfile does not follow semver for supported node isbinaryfile does not follow semver for supported node, use fixed version Mar 27, 2024
@mshima mshima marked this pull request as ready for review March 27, 2024 15:35
@SBoudrias SBoudrias merged commit a55415b into master Mar 27, 2024
15 checks passed
@SBoudrias SBoudrias deleted the isbinaryfile branch March 27, 2024 17:25
@SBoudrias
Copy link
Owner

Want to release this one and then do a major release with latest? I doubt we want to keep 14/16 compat going forward.

@mshima
Copy link
Collaborator Author

mshima commented Mar 27, 2024

We already dropped node 14/16 in current major.

@mshima
Copy link
Collaborator Author

mshima commented Mar 27, 2024

But this causes yeoman/yo#785 (comment) (the warning).

The fix would be to release mem-fs-editor v9 and v10 with isbinaryfile pinned at v5.0.0.

The PR is intended to don't have this problem again going forward.

@SBoudrias
Copy link
Owner

Ah I see. The problem IMO is it'll be a game of whack a mole, if not this dependency, it'll be another one or anywhere through another transitive dep. It's hard to maintain support outside LTS Node version. (no concern fixing this here, but in the grand scheme of things, I don't think it'll have a big impact on users)

@mshima
Copy link
Collaborator Author

mshima commented Mar 27, 2024

Yes, I'm just avoiding breaking in the future, I don't plan to release another v9 and v10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants