Seamless integration with FetchContent #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When repa is included in a parent project via FetchContent, CMAKE_SOURCE_DIR and CMAKE_BINARY_DIR refer to the parent project, while PROJECT_SOURCE_DIR and PROJECT_BINARY_DIR still refer to repa.
When repa is included in a parent project via FetchContent, the parent project options are inherited in the repa project, which can lead to name conflicts. For example, the parent project may want to build and run its own tests but none of the repa tests.
|
The reasons motivating the proposed changes are summarized in espressomd/espresso#4474 (comment). While we plan on namespacing the ESPResSo project options too, it doesn't fully resolves the issue of option name collisions, since populated projects can also conflict with one another. If the proposed changes are accepted in repa, the corresponding Spack installation script will need to be updated accordingly depending on the repa version. |
|
Changes look good, thanks for the contribution |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow populating the repa project in a parent project via the
FetchContentmethod, which uses a commonCMakeCache.txtfile to manage the state of the parent project and all populated projects. Replace CMake relative paths by project-specific relative paths and add a prefix to the repa project options to avoid name collisions with the options of the parent project and the other populated projects.