Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Books cart and checkout page #138

Merged
merged 31 commits into from
Feb 26, 2023
Merged

Books cart and checkout page #138

merged 31 commits into from
Feb 26, 2023

Conversation

s-orug
Copy link
Contributor

@s-orug s-orug commented Feb 23, 2023

This pr is for the carts page and the ability to add books to the cart.

@wihobbs
Copy link
Collaborator

wihobbs commented Feb 24, 2023

Ok, I can:

  • Add books to my cart
  • Try to check out, and if I'm not logged in it will redirect me to login
  • Check out once logged in

It cannot:

  • deduct a user balance via mongo.

@wihobbs
Copy link
Collaborator

wihobbs commented Feb 26, 2023

For my own note: we need to update the release notes with a customer account that has an ACTIVE balance for purchasing books

@rahulbulusu
Copy link
Contributor

I am getting this error after running npm i already:
image

@wihobbs
Copy link
Collaborator

wihobbs commented Feb 26, 2023

@rahulbulusu did you run npm i in both the client, backend, and root directories? remember there are separate package.json files in all of those

@rahulbulusu
Copy link
Contributor

It works now I am looking at it right now

Copy link
Contributor

@rahulbulusu rahulbulusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

image

image

Everything looks to be working as seen from the screenshots. I didn't catch any bugs so awesome work on this Sai!!

Copy link
Collaborator

@wihobbs wihobbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM! I was able to check out and see the balance deducted. I went into Mongo and manually put 5k in [email protected]'s account (password email) and that's the account I'm going to give to Vidal.

I will give @jackcoberman until 1pm-ish to see if he has any changes. Then I'm merging and deploying this and we're calling Beta done.

@wihobbs wihobbs mentioned this pull request Feb 26, 2023
4 tasks
@rahulbulusu rahulbulusu merged commit eeeb1b6 into main Feb 26, 2023
@wihobbs wihobbs mentioned this pull request Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants