Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Best Selling and New Arrivals work #220

Merged
merged 3 commits into from
Apr 11, 2023
Merged

Conversation

jackcoberman
Copy link
Contributor

This is the final PR - the one that actually addresses #206 . Best Selling and New Arrivals now function accurately for sorting on the browse page. Relevant is still not working - do we know what our intention for relevant was?
image

Copy link
Contributor

@linalfred08 linalfred08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that relevant was like related to the user's search

Base automatically changed from jack-order-userId to main April 11, 2023 21:37
Copy link
Contributor

@rahulbulusu rahulbulusu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best selling works and new arrivals works!! Good job!

@jackcoberman jackcoberman merged commit b165599 into main Apr 11, 2023
@jackcoberman jackcoberman deleted the jack-best-selling-new-release branch April 11, 2023 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants