s orug issue 40 #66
Merged
s orug issue 40 #66
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-orug
requested review from
wihobbs,
jackcoberman,
linalfred08 and
rahulbulusu
jackcoberman
previously approved these changes
Nov 27, 2022
There was a problem hiding this comment.
Really really impressive work Sai. I ran it on my device and it looks fantastic - def a lot of cleaning but still very great work. The @media function is a higher level than I anticipated seeing this early on in the project - super nice. I left two comments that were formatting things I'm okay with ignoring and one clarification question.
| First Name | ||
| <div className="form-inputs space"> | ||
| <label htmlFor="firstname" className="form-label"> | ||
| First Name |
There was a problem hiding this comment.
What's the purpose of the  ?
There was a problem hiding this comment.
In this case,   adds a space between the input fields and the labels of the signup form.
With  :
Without  :
Closed
jackcoberman
approved these changes
Nov 27, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the Login page along with create account and their corresponding navigation.