Deployment Scripts and (partial) rewrite of Backend Code #74
Conversation
wihobbs
changed the title
|
This is ready for a review sometime tomorrow but is already rolled to deployment (to show that it works). Important note: we removed the client package-lock.json (and maybe the root dir too?) to get Heroku to deploy (as suggested on their support website.) |
| console.log(path.join(__dirname, 'client/build')); | ||
| app.use(express.static(path.join(__dirname, 'client/build'))); | ||
| app.get('*', (req,res) => { | ||
| res.sendFile(path.resolve(__dirname, 'client', 'build', 'index.html')); |
There was a problem hiding this comment.
Is it supposed to be index.html for our purposes?
|
@wihobbs Currently getting 404 errors when running this in local development - also we need to fix readme to reflect both ".env" and that we are now running "npm run dev" instead of "npm start" |
|
@jackcoberman Are you sure you're navigating to the correct port on your local device? We changed that a few times and I believe 3001 is the one we settled on, but just want to be sure. I haven't seen that 404 error before -- if you can shoot me a screenshot I'll look into it more. |
|
I think for now we should deprecate Build the code -- This will start the server and the client, and they can communicate with each other (on my machine and our deployment). Goes without saying that you need |
test pr