Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

206: Fix linting errors & Formatting #211

Merged
merged 9 commits into from
Jan 25, 2024
Merged

206: Fix linting errors & Formatting #211

merged 9 commits into from
Jan 25, 2024

Conversation

evan-scales
Copy link
Collaborator

@evan-scales evan-scales commented Jan 23, 2024 •
edited
Loading

  • Fixed all the es lint errors
  • Format check still failing, weird... Not sure what to do here. I ran the formatter, confirmed with npm run format-check byt that same command says the format is not pretty in the workflow
    • Should we just get rid of the step?

@evan-scales evan-scales linked an issue Jan 23, 2024 that may be closed by this pull request
Fix linting errors & Formatting #206
Closed
@jbytes1027
Copy link
Contributor

Failing format check was was caused by line endings changing on checkout. See here.

@jbytes1027 jbytes1027 merged commit c568d65 into main Jan 25, 2024
2 checks passed
@jbytes1027 jbytes1027 deleted the 206 branch January 25, 2024 17:03
@jbytes1027 jbytes1027 mentioned this pull request Jan 28, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbytes1027 jbytes1027 jbytes1027 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix linting errors & Formatting
2 participants
@evan-scales @jbytes1027