Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #106

Merged
merged 8 commits into from
May 18, 2022
Merged

fix #106

merged 8 commits into from
May 18, 2022

Conversation

gaetschwartz
Copy link
Collaborator

@gaetschwartz gaetschwartz commented May 5, 2022 •
edited
Loading

Improve tests stability :)

leonardopennino
leonardopennino approved these changes May 6, 2022
View reviewed changes
Copy link
Collaborator

@leonardopennino leonardopennino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feature is very welcome, nicely done!

@gaetschwartz gaetschwartz added the Waiting for review This PR is waiting for review. label May 17, 2022
@gaetschwartz gaetschwartz self-assigned this May 17, 2022
bhvrgav
bhvrgav approved these changes May 18, 2022
View reviewed changes
Copy link
Collaborator

@bhvrgav bhvrgav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@bhvrgav bhvrgav merged commit ab57db2 into main May 18, 2022
@bhvrgav bhvrgav deleted the fix/quick-fix-issues-firebase branch May 18, 2022 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhvrgav bhvrgav bhvrgav approved these changes

@panadax panadax Awaiting requested review from panadax

@leonardopennino leonardopennino Awaiting requested review from leonardopennino

@adam-narozniak adam-narozniak Awaiting requested review from adam-narozniak

@SilvioMueller SilvioMueller Awaiting requested review from SilvioMueller

Assignees

@gaetschwartz gaetschwartz

Labels
actual: 4h Waiting for review This PR is waiting for review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gaetschwartz @leonardopennino @bhvrgav