Feat/tictactoelocalmult #125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaetschwartz
requested changes
May 19, 2022
Comment on lines
6
to
23
| class MultiplayerTicTacToe(val view:TicTacToeFragment,player:MOVES) : TicTacToeGame(player){ | ||
| override fun putChoice(square: Int) { | ||
| if(!gameRunning) | ||
| return | ||
| val cell = square % 3 | ||
| val row = (square / 3) | ||
| if(matrix[row][cell] != MOVES.EMPTY) | ||
| return | ||
| matrix[row][cell] = player | ||
| view.updateUI(square, player) | ||
| calculate() | ||
| player = if(player == MOVES.CROSS) MOVES.CIRCLE else MOVES.CROSS | ||
| } | ||
| override fun gameOver(winner:MOVES){ | ||
| gameRunning = false | ||
| view.gameOver(winner) | ||
| } | ||
| } |
There was a problem hiding this comment.
Are you sure this is the best approach ? I would prefer not change UI in the logic here, but instead only update the current state, and then ui listens for changes and updates the UI.
There was a problem hiding this comment.
Sure that would be an approach too! I choose this one because in your approach I needed to have an observer for the TTT state which is a bit more problematic to implement correctly while with a callback based approach it was super straightforward and easy to implement.
Sure thank you for reminding me! |
leonardopennino
added
estimated: 7h
gaetschwartz
approved these changes
May 19, 2022
adam-narozniak
approved these changes
May 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch optimises current TTT implementation to follow android best practices in fragment managing and Navigation Paths. The interface of TTT has been slightly changed to allow better interoperability between different subclasses of TicTacToeGame. The following PR also adds support for local multiplayer.