Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better nav + cache improvement #131

Merged
merged 15 commits into from
May 26, 2022
Merged

Better nav + cache improvement #131

merged 15 commits into from
May 26, 2022

Conversation

gaetschwartz
Copy link
Collaborator

No description provided.

@gaetschwartz gaetschwartz marked this pull request as draft May 25, 2022 18:02
@gaetschwartz gaetschwartz marked this pull request as ready for review May 25, 2022 19:18
panadax
panadax approved these changes May 25, 2022
View reviewed changes
Copy link
Collaborator

@panadax panadax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one small issue about coverage: it seems Matchmaking and loading fragment show really low coverage, is it possible to improve it somewhat?

@gaetschwartz gaetschwartz mentioned this pull request May 26, 2022
Closed
18 tasks
@gaetschwartz
Copy link
Collaborator Author

LGTM, one small issue about coverage: it seems Matchmaking and loading fragment show really low coverage, is it possible to improve it somewhat?

It can be mproved indeed, will look into it. Most of the setup can't really as it uses firebase, but the navigation can be.

leonardopennino
leonardopennino approved these changes May 26, 2022
View reviewed changes
Copy link
Collaborator

@leonardopennino leonardopennino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing the test in the cache!

@gaetschwartz gaetschwartz merged commit f29d550 into main May 26, 2022
@gaetschwartz gaetschwartz deleted the feat/better_nav_cache branch May 26, 2022 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonardopennino leonardopennino leonardopennino approved these changes

@panadax panadax panadax approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gaetschwartz @panadax @leonardopennino