Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Implement test for main navigation #27

Merged
merged 1 commit into from
Mar 14, 2022

Conversation

SilvioMueller
Copy link
Collaborator

I added the tests that are possible for now. Can be extended when other pages are connected.

Copy link
Collaborator

@gaetschwartz gaetschwartz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@adam-narozniak adam-narozniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sticking to one naming convention would be better for the clean code. Besides that LGTM

@get:Rule
val testRule = ActivityScenarioRule(MainActivity::class.java)

@Test
fun pressingGreetingButton() {
val name = "John"
fun clickOnStatistics_OpensStatisticFragment() {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function name like here can be less repetitive and follow one naming convention (camelCase). Besides that LGTM

@SilvioMueller SilvioMueller merged commit f14dc06 into main Mar 14, 2022
@SilvioMueller SilvioMueller deleted the feat/main-page-ui-tests branch March 14, 2022 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants