Re-Adding Friend Page features after reset #43
Conversation
- Dynamic toasts based on which button is clicked
|
Still tests missing, add them and we will be fine. Again really a great job 👍 keep up the good work 💯 ! |
|
This design looks good to me 👍 Don't forget to check to update with the main branch before your development |
- Tests Incomplete
- Able to pass info from friends page to info page - able to navigate from infopage > game page - wrote tests, all passed when checked individually
This reverts commit 8f9c6bb.
- Same issue as before
- added ID for game fragment
bhvrgav
dismissed
leonardopennino’s stale review
Wrote tests, have yet to fix UI
| data class FriendsInfo( | ||
| val username : String, | ||
| val gamesPlayed : Int, | ||
| val gamesWon : Int, |
There was a problem hiding this comment.
It seems a bit weird to me to have this class here. But I am not sure. Maybe this could be in models??
There was a problem hiding this comment.
You're right, let me move that.
There was a problem hiding this comment.
I will also work on changing to UI in the next sprint to match the rest of the application. Didn't have enough time for that this week
| val friendName : TextView = itemView.findViewById(R.id.friendName) | ||
| val winRate : TextView = itemView.findViewById(R.id.winRateText) | ||
| val gamesPlayed : TextView = itemView.findViewById(R.id.gamesPlayedText) | ||
| val gamesWon : TextView = itemView.findViewById(R.id.gamesWonText) |
There was a problem hiding this comment.
I think its best practice to use bindings instead of findViewByID. It reduces the boilerplate code
There was a problem hiding this comment.
I will discuss this with your tomorrow, and I will fix it before the next PR! Thank you for the comments :)
Added navigation, new info page and wrote tests.