Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implementation of settings page #62

Merged
merged 8 commits into from
Apr 6, 2022
Merged

Implementation of settings page #62

merged 8 commits into from
Apr 6, 2022

Conversation

gaetschwartz
Copy link
Collaborator

i hate android with a passion

Closes #60

@gaetschwartz
early implementation of settings page
8edfbe8 
i hate android with a passion
@gaetschwartz gaetschwartz marked this pull request as draft April 4, 2022 16:26
@gaetschwartz gaetschwartz marked this pull request as ready for review April 6, 2022 15:06
@gaetschwartz gaetschwartz added the Waiting for review This PR is waiting for review. label Apr 6, 2022
SilvioMueller
SilvioMueller approved these changes Apr 6, 2022
View reviewed changes
Copy link
Collaborator

@SilvioMueller SilvioMueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Very cool that you clean up all the unneeded dependencies in the tests and unified the naming of the UI elements in the main fragment!

leonardopennino
leonardopennino approved these changes Apr 6, 2022
View reviewed changes
Copy link
Collaborator

@leonardopennino leonardopennino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@gaetschwartz gaetschwartz merged commit be27a77 into main Apr 6, 2022
@gaetschwartz gaetschwartz deleted the feat/settings-page branch April 6, 2022 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonardopennino leonardopennino leonardopennino approved these changes

@SilvioMueller SilvioMueller SilvioMueller approved these changes

Assignees
No one assigned
Labels
Waiting for review This PR is waiting for review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement the settings page
3 participants
@gaetschwartz @SilvioMueller @leonardopennino